Enable fetching external data from the Microsoft Planetary Computer #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lossyrob
changed the title
gadomski
approved these changes
Sep 13, 2021
This commit allows external data to be fetched from Azure through the Microsoft Planetary Compture. Data access requires an anonymous SAS token be attached to the URL, which this code fetches and uses for any external data marked with "planetary_computer": True.
gadomski
force-pushed
the
feature/rde/pc-data
branch
from
a29d087 to
e2b03b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you submit a pull request, please fill in the following:
Description:
Allow external data from the Microsoft Planetary Computer.
The PC hosts data that allows for anonymous download, but URLs must be signed first by requesting a token from
https://planetarycomputer.microsoft.com/api/sas/v1/sign?href={URL}. This PR allows external test data to be marked with"planetary_computer": True, and modifies the logic to sign the URL of that external data if that flag is present.In addition, mypy is unpinned in this repository so upgraded to a post-0.9 release, which caused some fixes to be required. Mypy no longer holds stubs for common libraries and so the linting script is changed to account for this. Also mypy errors on a type issue it hadn't before for a local variable in the projection logic, and an
Anyis put in place to avoid that issue.PR checklist:
scripts/format).scripts/lint).scripts/test).