-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vanadis examples 2 #2439
base: devel
Are you sure you want to change the base?
Vanadis examples 2 #2439
Conversation
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some comments since this is an example file to help people understand what the config is doing?
mmuType = "simpleMMU" | ||
|
||
# Define SST core options | ||
sst.setProgramOption("timebase", "1ps") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these two lines, they are not needed. "stop-at" can be used to force the simulation to stop at a certain time but "timebase" very rarely needs to be (or should be) changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I'll take care of it.
sst.setStatisticOutput("sst.statOutputConsole") | ||
|
||
# full_exe_name = os.getenv("VANADIS_EXE", "./small/" + testDir + "/" + exe + "/" + isa + "/" + exe ) | ||
full_exe_name = "/home/skinkea/sst/sst-elements/sst-elements-src/src/sst/elements/vanadis/tests/small/basic-io/hello-world/riscv64/hello-world" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make directory path relative so that it is runnable from the examples directory.
full_exe_name = "/home/skinkea/sst/sst-elements/sst-elements-src/src/sst/elements/vanadis/tests/small/basic-io/hello-world/riscv64/hello-world" | ||
exe_name= full_exe_name.split("/")[-1] | ||
|
||
verbosity = int(os.getenv("VANADIS_VERBOSE", 0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be helpful to add a comment describing each environment variable since this file is an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on it.
@@ -0,0 +1,510 @@ | |||
import os | |||
import sst | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment here describing what memory system/core config this file describes (e.g., single core, 3-level cache hierarchy with one memory) and how to run it and if any parameters need to be changed (e.g., paths) to get it to run.
will do. |
THis pull requests creates an example for the vanadis element. The example demonstrates creating a simple simulation of a CPU on RISC-V architecture with L1, L2, and L3 caches. This example runs a hello-world on this CPU.
Instructions for Issuing a Pull Request to sst-elements
1 - Verify that the Pull Request is targeted to the devel branch of sstsimulator/sst-elements
2 - Verify that Source branch is up to date with the devel branch of sst-elements
3 - After submitting your Pull Request:
4 - DO NOT DELETE THE BRANCH (OR FORKED REPO) UNTIL THE PULL REQUEST IS MERGED.