Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve handling of exceptions for googletrans #244

Merged
merged 2 commits into from
Feb 5, 2025
Merged

improve handling of exceptions for googletrans #244

merged 2 commits into from
Feb 5, 2025

Conversation

iulusoy
Copy link
Member

@iulusoy iulusoy commented Feb 5, 2025

  • truncate text for googletrans to 5000 characters. At the moment, this is set globally, so the original text is truncated in the dict. However, one could also truncate a temporary variable and keep the original text at its original length (could result in a possibly longer text in the original than in the translation). This closes Simple text translation (from csv file) breaking off #240
  • skip translation if an error occurs, to avoid interruptions of the execution. This closes Text detector- move on after error #237

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@iulusoy iulusoy merged commit 3cf1b54 into main Feb 5, 2025
6 checks passed
@iulusoy iulusoy deleted the truncate-text branch February 5, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simple text translation (from csv file) breaking off Text detector- move on after error
1 participant
@iulusoy