Serious Performance Issue with New $interval added 1.2.2

[onemenny]

@sergiovilar Commited a change 68c505d

This causes a serious performance degregation since the count was removed from the $interval call - it causes a digest loop to run indefinitely which will slow down to the ground every application

The new version 1.2.2 is just not usable and should revert to 1.2.0

[sroze]

Can't it be the same as #186 ?
On Wed, 20 Jan 2016 at 09:07, Menny Rachmanny (onemenny) <
[email protected]> wrote:

@sergiovilar https://github.com/sergiovilar Commited a change
https://githubcom/sroze/ngInfiniteScroll/commit/68c505d131e14b6e4997ab83dc675d67209634ad

This causes a serious performance degregation since the count was
removed from the $interval call - it causes a digest loop to run
indefinitely which will slow down to the ground every application

The new version 122 is just not usable and should revert to 120

—
Reply to this email directly or view it on GitHub
#235.

[onemenny]

No, it does not matter if reach the end, It is related that the $interval method works indefinitely causing an endless digest cycles

[sergiopvilar]

Hey, sorry about that. There's any suggestion to fix the issue?

[onemenny]

Sorry, I don't know what this fix meant to do, I have no problems with 1.2.0. One can always use the disable option, If you can elaborate I'll be happy to help

[morgoth]

I confirm the issue. Angular tests in our app started to fail with timeout. Reverting to 1.2.1

[pudo]

Confirmed here, too. Showstopper.

[pierrebeitz]

+1

[dirkgroenen]

Same issues over here, looks like the $interval on line 203 is running each ms. Didn't check why the interval needs to run, but it might be worthy to check if we can't change it to the browser's native setInterval so we don't call a digest cycle each millisecond.

[dirkgroenen]

@sergiovilar before making any suggestions, what was the reason for adding the interval and making it run the digest cycle?

[timburnham73]

+1 I have the same problem. It broke our protractor tests in chrome only. Firefox worked which is strange.

[scottmollon-invicara]

+1 breaking all our protractor tests!

[000panther]

+1 I can confirm this issue, and confirm that it works when you change the code back. what does the new code do anyway?

[sroze]

@sergiovilar could you PR a fix please?

[jmlora]

+1 I have this problem with 1.2.2, not in 1.2.0.

[feimosi]

+1, also happens on 1.2.2

[pelizza]

+1, happens on 1.2.2 but not on 1.2.1.

[belfz]

+1, although for me it happens on 1.2.1.

[onemenny]

@sroze @sergiovilar
Can someone please revert this commit, this is starting to be embarrassing.

[janhartigan]

@onemenny just revert to an old release on your app until this is fixed.

[david-gang]

In my opinion it should be at least mentioned in the readme just to use 1.2.0

[onemenny]

@janhartigan That's exactly what I did, but still, this is kind of ridicules that the main version is not functioning for that long. @david-gang is right

[scanferla]

+1

Took me and my team quite some time to figure this one out 😢

[sroze]

True, I'll fix that today.
On Wed, 9 Mar 2016 at 04:25, Gustavo Scanferla [email protected]
wrote:

+1

Took me and my team quite some time to figure this one out 😢

—
Reply to this email directly or view it on GitHub
#235 (comment)
.

[stephenycchang]

I'm having an issue where there are over 200 digests per second just from implementing this plugin in a sample barebone project. Think it's related as well.

[miguelolmo]

+1 reverting to 1.2.1 fixed it for me

[belfz]

What's the status of that? Version 1.2.0 doesn't work for me (it doesn't have infiniteScrollListenForEvent), and version 1.2.1 (I'm using npm) was not fixed yet.

[woutrbe]

Reverting to 1.2.1 or 1.2.0 didn't work for me. Is there any update on this?

[belfz]

There was a pull request merged and closed recently, but no new version released yet. @sroze could you release at least patch version? Thank you in advance.

[peder]

Some users report that this is not working in 1.2.1 either. Can anyone confirm that the Pull Request changes fix the issue? Also, any update on publishing 1.2.3?

[graingert]

NPM "ng-infinite-scroll": "1.2.0", is the only one that works for me.

[eXaminator]

We are also experiencing this, more than 3 month after this serious bug was reported it is still not resolved. Please release a new version with a fix for this (as someone stated it seems to be merged) and publish it to NPM (it seems the last version on NPM is 1.2.1 while github already has 1.2.2).

[graingert]

@onemenny @eXaminator please try 1.3.0

[mephinet]

Tested 1.3.0 - $interval has it's 3rd parameter again, performance is back to normal. Thanks, @graingert for fixing this!