Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses issue #31 : remove query strings from parameters #36

Merged
merged 2 commits into from
Aug 28, 2022
Merged

Addresses issue #31 : remove query strings from parameters #36

merged 2 commits into from
Aug 28, 2022

Conversation

sroehrl
Copy link
Owner

@sroehrl sroehrl commented Aug 28, 2022

V2: moving sanitation to Request.php - where it belongs

@sroehrl
Addresses issue #31 : remove query strings from parameters
905a257 
V2: moving sanitation to Request.php - where it belongs
@github-actions
Copy link

Coverage after merging bugfixes into master

98.79%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\CoreInterfaces\RequestInterface.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\CoreInterfaces\ResponseInterface.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Database\Adapter.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Database\Database.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Database\NeoanSQLTranslator.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Database\SqLiteAdapter.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Enums\AttributeType.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Enums\Direction.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Enums\GenericEvent.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Enums\RequestMethod.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Enums\ResponseOutput.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Enums\TransactionType.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Errors\NotFound.phpN/A100%80%19
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Errors\Unauthorized.phpN/A100%75%15
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Event\Event.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Event\EventNotification.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Event\Listenable.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Helper\AttributeHelper.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Helper\ComposerParser.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Helper\DataNormalization.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Helper\DateHelper.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Helper\Env.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Helper\FileParser.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Helper\Terminate.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Helper\VerifyJson.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Attributes\HasMany.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Attributes\Ignore.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Attributes\Initialize.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Attributes\IsForeignKey.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Attributes\IsPrimaryKey.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Attributes\IsUnique.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Attributes\Transform.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Attributes\Type.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Collection.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Interfaces\ModelAttribute.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Interfaces\ModelClass.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Interfaces\Transformation.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Interpreter.phpN/A100%98.28%142
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Model.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Traits\Setter.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Traits\TimeStamps.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Transformers\CurrentTimeIn.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Transformers\Hash.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\NeoanApp.phpN/A100%91.67%27
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Render\RenderEngine.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Render\Renderer.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Request\Request.phpN/A100%98.41%158
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Response\Response.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\AttributeRouting.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Attributes\Delete.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Attributes\Get.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Attributes\Patch.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Attributes\Post.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Attributes\Put.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Attributes\Route.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Attributes\RouteAttribute.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Attributes\Web.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Route.phpN/A100%95%109, 160, 205, 214
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Store\Store.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Store\Store.phpN/A100%100%

@github-actions
Copy link

Coverage after merging bugfixes into master

98.79%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\CoreInterfaces\RequestInterface.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\CoreInterfaces\ResponseInterface.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Database\Adapter.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Database\Database.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Database\NeoanSQLTranslator.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Database\SqLiteAdapter.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Enums\AttributeType.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Enums\Direction.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Enums\GenericEvent.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Enums\RequestMethod.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Enums\ResponseOutput.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Enums\TransactionType.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Errors\NotFound.phpN/A100%80%19
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Errors\Unauthorized.phpN/A100%75%15
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Event\Event.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Event\EventNotification.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Event\Listenable.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Helper\AttributeHelper.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Helper\ComposerParser.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Helper\DataNormalization.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Helper\DateHelper.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Helper\Env.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Helper\FileParser.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Helper\Terminate.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Helper\VerifyJson.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Attributes\HasMany.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Attributes\Ignore.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Attributes\Initialize.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Attributes\IsForeignKey.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Attributes\IsPrimaryKey.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Attributes\IsUnique.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Attributes\Transform.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Attributes\Type.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Collection.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Interfaces\ModelAttribute.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Interfaces\ModelClass.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Interfaces\Transformation.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Interpreter.phpN/A100%98.28%142
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Model.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Traits\Setter.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Traits\TimeStamps.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Transformers\CurrentTimeIn.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Model\Transformers\Hash.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\NeoanApp.phpN/A100%91.67%27
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Render\RenderEngine.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Render\Renderer.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Request\Request.phpN/A100%98.41%158
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Response\Response.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\AttributeRouting.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Attributes\Delete.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Attributes\Get.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Attributes\Patch.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Attributes\Post.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Attributes\Put.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Attributes\Route.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Attributes\RouteAttribute.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Attributes\Web.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Routing\Route.phpN/A100%95%109, 160, 205, 214
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Store\Store.phpN/A100%100%
C:\xampp\htdocs\neoan.io-tools\lenkrad-core\src\Store\Store.phpN/A100%100%

@sroehrl sroehrl merged commit 0fb92c1 into master Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sroehrl