-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernized Preview #2
base: master
Are you sure you want to change the base?
Conversation
NoteOnly the preview for archive files supported by libarchive is modified. The previews generated for binhex and .sit files remain unchanged. However, since i don't have compatible archives i currently cannot test them. |
@mbrotz not sure when this one is getting merged but how easy is this to build myself? Or to provide a build version of your improvements? thanks |
@koenvb You can simply open the project in xcode and hit the run button to build it. By the way, i talked to @srirangav via email already. He said he would be happy to merge the changes. I also attached two screenshots here. Manuel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added support for a universal binary in the Xcode project.
Do i have to resolve the conflicts? |
Conflicts are very minimal and not worth the delay. I made PR with resolved conflicts for your repo, and you can update this PR. |
Modernized the layout and appearance to more closely match the Finder
Any chance this is gonna be merged anytime soon? :) |
Hi, I installed qlZipInfo following the instructions (placed in ~/Library/QuickLook, set permissions, and reloaded Quick Look), but it’s not working on macOS Sequoia 15.1 with an M1 Pro chip. Quick Look does not preview ZIP files. Any suggestions to troubleshoot this? |
Apple has removed support for QuickLook generators and has moved to a different method in MacOS Sequoia (see: https://eclecticlight.co/2024/10/31/how-sequoia-has-changed-quicklook-and-its-thumbnails/). I don't have a good example of how to re-implement this using Apple's new method. If I can find a good example, perhaps I will be able to rewrite this. Sorry for any inconvenience. -ranga |
Thanks for the update and the link @srirangav ! |
- update to libarchive 3.7.7
Hi, I merged some of the proposed changes into the latest version. I will merge some additional changes into the next version. FYI, I am not sure what to do about the SVG icons because they seem to make things slower on large files on my older Macs. Thanks, -ranga |
Hi Great to hear! :) Yes, i can imagine that the svg icons might cause a slowdown on large files since the svg code for every icon has to be inserted explicitly for every item. A possibility would be to simply not display them if the number of items is large, for example more than 1000 or so. I wasn't able to embed the files into the executable and then refer to them from within the generated preview. I just don't know how to reference them, if it is even possible. If the icons could be embedded into the executable we could also pre render them as png files. That might mitigate the performance issues... Manuel |
These changes improve the layout and appearance of the generated preview to more closely match the Finder.