Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MinGW: Fix ext_ad_group_acl build errors #2005

Closed
wants to merge 3 commits into from
Closed

MinGW: Fix ext_ad_group_acl build errors #2005

wants to merge 3 commits into from

Conversation

kinkie
Copy link
Contributor

@kinkie kinkie commented Feb 27, 2025

  • Add curly braces to avoid ambiguous if statement
  • Do some AAA, fix const mismatch
  • Use bool return type for static function
  • Update win32 API calls in ext_ad_group_acl
    in c++, win32 APIs want references, not pointers

@kinkie
mingw: use namleess unions in ext_ad_group_acl
87083ad
@kinkie
Stop leaking BSTRs
48f53e8
@kinkie
mingw: Fix build errors for ext_ad_group_acl
fbaa77f 
Add curly braces to avoid ambiguous if statement
Do some AAA, fix const mismatch
Use bool return type for static function
Update win32 API calls in ext_ad_group_acl
  in c++, win32 APIs want references, not pointers
@kinkie kinkie closed this Feb 27, 2025
@squid-anubis squid-anubis added the M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels label Feb 27, 2025
@rousskov rousskov removed the M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kinkie @rousskov @squid-anubis