CI: Revert recent "show build commands on terminal" change #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinkie
changed the title
rousskov
changed the title
rousskov
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Thank you for posting this PR!
I have pushed a commit to finish reversal of e5a66fc: When reverting a commit, we should be reverting that commit as a whole, not undoing some of that commit changes while keeping others (even if we like some of the changes in the being-reverted commit). Some of the leftovers (removed in my commit 620f4bf) were plain wrong. Some may be a good idea but should be submitted in a dedicated PR (where they may be expanded or polished as needed, in that new context).
I adjusted PR title to become more meaningful in isolation (e.g., in a list of commit titles and/or in another branch). I adjusted PR description to state the facts without an unnecessary (and incomplete) list of those who observed those facts. I also left a bit more breadcrumbs in case we decide to revisit this topic in future PRs.
If you are OK with these adjustments, please clear this PR for merging.
Time spent so far: 7 hours and 8 minutes
rousskov
added
the
S-waiting-for-author
What's worse, we're back to square one, fundamental disagreement about |
kinkie
added
M-cleared-for-merge
squid-anubis
pushed a commit
that referenced
this pull request
Feb 23, 2025
GitHub Actions UI does not handle large amounts of console output with collapsable `::group::` sections well. For example, UI may truncate console output if a collapsable `::group::` section gets too many log lines. In some cases, GitHub does not report truncation at all, resulting in misleading console output. In other, UI warns: "This step has been truncated due to its large size. Download the full logs from the menu once the workflow run has completed." This change reverts recent commit e5a66fc.
squid-anubis
added
the
M-waiting-staging-checks
rousskov
added
the
S-waiting-for-QA
squid-anubis
pushed a commit
that referenced
this pull request
Feb 24, 2025
GitHub Actions UI does not handle large amounts of console output with collapsable `::group::` sections well. For example, UI may truncate console output if a collapsable `::group::` section gets too many log lines. In some cases, GitHub does not report truncation at all, resulting in misleading console output. In other, UI warns: "This step has been truncated due to its large size. Download the full logs from the menu once the workflow run has completed." This change reverts recent commit e5a66fc.
squid-anubis
added
M-failed-staging-other
rousskov
removed
S-waiting-for-QA
squid-anubis
added
the
M-waiting-staging-checks
rousskov
added
the
S-waiting-for-QA
squid-anubis
added
M-merged
rousskov
removed
the
S-waiting-for-QA
kinkie
added a commit
to kinkie/squid
that referenced
this pull request
Feb 26, 2025
…he#2000) GitHub Actions UI does not handle large amounts of console output with collapsable `::group::` sections well. For example, UI may truncate console output if a collapsable `::group::` section gets too many log lines. In some cases, GitHub does not report truncation at all, resulting in misleading console output. In other, UI warns: "This step has been truncated due to its large size. Download the full logs from the menu once the workflow run has completed." This change reverts recent commit e5a66fc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions UI does not handle large amounts of console output with
collapsable
::group::sections well.For example, UI may truncate console output if a collapsable
::group::section gets too many log lines. In some cases, GitHub does not report
truncation at all, resulting in misleading console output. In other, UI
warns: "This step has been truncated due to its large size. Download the
full logs from the menu once the workflow run has completed."
This change reverts recent commit e5a66fc.