squid-conf-tests: Ignore tests with mismatching autoconf macro #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'skip-unless-autoconf-defines' directive should be able to distinguish autoconf macro values, such as '0' (not defined) from '1' (defined) ones. For example, --disable-ipv6 configuration option defines USE_IPV6 as '0'. This fix allowed to activate the IPv6 tests marked with a TODO.
yadij
previously approved these changes
Jan 25, 2024
yadij
added
the
M-cleared-for-merge
|
Status update: @eduard-bagdasaryan is working on addressing Jenkins check failures. |
rousskov
added
the
S-waiting-for-author
kinkie
removed
the
M-cleared-for-merge
|
This seems to be causing some issues on the unit tests. Retracting the "clear for merge" signal |
eduard-bagdasaryan
dismissed stale reviews from yadij and rousskov
via
e95be10
rousskov
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
@eduard-bagdasaryan, thank you for figuring out what was wrong with Jenkins nodes.
@kinkie, thank you for enabling IPv6 on Jenkins nodes.
rousskov
added
M-cleared-for-merge
squid-anubis
pushed a commit
that referenced
this pull request
Feb 20, 2024
The 'skip-unless-autoconf-defines' directive should be able to distinguish autoconf macro values, such as '0' (not defined) from '1' (defined) ones. For example, --disable-ipv6 configuration option defines USE_IPV6 as '0'. This change allows IPv6 tests activation, addressing a TODO.
squid-anubis
added
the
M-waiting-staging-checks
rousskov
added
S-waiting-for-QA
squid-anubis
added
M-merged
kinkie
pushed a commit
to kinkie/squid
that referenced
this pull request
Feb 23, 2024
…-cache#1648) The 'skip-unless-autoconf-defines' directive should be able to distinguish autoconf macro values, such as '0' (not defined) from '1' (defined) ones. For example, --disable-ipv6 configuration option defines USE_IPV6 as '0'. This change allows IPv6 tests activation, addressing a TODO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'skip-unless-autoconf-defines' directive should be able to
distinguish autoconf macro values, such as '0' (not defined) from '1'
(defined) ones. For example, --disable-ipv6 configuration option
defines USE_IPV6 as '0'. This change allows IPv6 tests activation,
addressing a TODO.