Make Sink and LayoutRunner fun interfaces. #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ktlint's not happy. Fix is on the way, see pinterest/ktlint#830 |
rjrjr
approved these changes
Aug 26, 2020
steve-the-edwards
approved these changes
Sep 2, 2020
zach-klippenstein
force-pushed
the
zachklipp/fun-interfaces
branch
from
3fca823 to
49c7ba9
Compare
|
Just rebased now that we landed 1.4. |
Yes, we can pass lambdas now instead of having to create anonymous objects. |
|
Need to update ktlint to land this, but that then complains about a bunch of our formatting. Tried reformatting in ide as well as using ktlintFormat task, it just got more and more confused about indentation. Need to review the tricks @vRallev used to make this work. |
This allows consumers to create anonymous instances of them with Kotlin's lambda syntax when using Kotlin 1.4.
zach-klippenstein
force-pushed
the
zachklipp/fun-interfaces
branch
from
49c7ba9 to
cfe7690
Compare
zach-klippenstein
changed the base branch from
main
to
zachklipp/fix-code-format
|
This should finally work, after upgrading out ktlint version in #277. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows consumers to create anonymous instances of them with Kotlin's lambda syntax when using Kotlin 1.4.