WireSchemaTests as MPP module #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Egorand
approved these changes
Jul 7, 2023
oldergod
force-pushed
the
bquenaudon.2023-07-07.mpp
branch
2 times, most recently
from
97c679c to
963206a
Compare
JakeWharton
approved these changes
Jul 7, 2023
wire-schema-tests/build.gradle.kts
Outdated
Comment on lines
17
to
20
| jvm { | ||
| withJava() | ||
| } |
There was a problem hiding this comment.
Suggested change
| jvm { | |
| withJava() | |
| } | |
| jvm() |
I don't see any Java sources in here, right?
There was a problem hiding this comment.
Looks like MavenPublishBaseExtension fails without it with SoftwareComponentInternal with name 'java' not found
oldergod
force-pushed
the
bquenaudon.2023-07-07.mpp
branch
from
e73690e to
c5dcc6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.