Aligned Additions #42
Conversation
kyleve
commented
Dec 16, 2019
kyleve
commented
- Add 'fill' options to the 'Aligned' element, to support content taking up the full width or height in each dimension.
- Add the UI tests to the 'SampleApp' workspace to allow running the tests.
|
Hmm, Travis is stuck, looking into it: |
| @@ -15,8 +15,6 @@ matrix: | |||
| xcode_destination: platform=iOS Simulator,OS=9.3,name=iPhone 4s | |||
| before_install: | |||
| - cd SampleApp | |||
| - gem update --system | |||
| - gem install bundler | |||
There was a problem hiding this comment.
These lines aren't needed – they're already on Travis.
| @@ -14,6 +14,9 @@ public struct Aligned: Element { | |||
| case center | |||
| /// Aligns the content to the bottom edge of the containing element. | |||
| case bottom | |||
|
|
|||
| /// The content fills the full vertical height of the containing element. | |||
| case fill | |||
There was a problem hiding this comment.
We should update the docs on this type if we add this, to something like:
For alignments other than
fill, the size of the content element is determined by callingmeasure(in:)on the content element – even if that size is larger than the wrapping element.
…g up the full width or height in each dimension.
kyleve
force-pushed
the
kve/add-fill-to-aligned
branch
from
a41ac1d to
d037231
Compare
| /// When using alignment mode `.fill`, the content is scaled to the width or height of the `Aligned` element. | ||
| /// | ||
| /// For other modes, the size of the content element is determined by calling `measure(in:)` | ||
| /// on the content element – even if that size is larger than the wrapping element. |
There was a problem hiding this comment.
@watt not going to change it here, but this bit "even if that size is larger than the wrapping element." seems a bit weird to me – is there a use case for this, or should we change the implementation to cap the size?
There was a problem hiding this comment.
I copied this from Centered. I think it's reasonable behavior, as it limits the responsibility of this element and favors composition (also a reason that I have mixed feelings about adding fill here instead of introducing a Fill element). If you want to cap the size of an element, composition with ConstrainedSize seems like a more scalable solution.
