Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift Package Manager support #37

Merged
merged 6 commits into from
Nov 14, 2019
Merged

Swift Package Manager support #37

merged 6 commits into from
Nov 14, 2019

Conversation

timdonnelly
Copy link
Contributor

No description provided.

@timdonnelly
Copy link
Contributor Author

  • Adds Package.swift for SPM support.
  • Moves snapshot tests to Xcode 11.2/iOS 13.2 via SPM.
  • Keeps a BlueprintUI test pass via Cocoapods for completeness.
  • Adds a bunch of missing imports that are required when building via SPM.
  • Moves vector code to modern Swift SIMD types to avoid warnings.

@timdonnelly timdonnelly changed the title [wip] Swift Package Manager support Swift Package Manager support Nov 14, 2019
kyleve
kyleve reviewed Nov 14, 2019
View reviewed changes
Podfile.lock Show resolved Hide resolved
@timdonnelly timdonnelly merged commit 637327e into master Nov 14, 2019
@timdonnelly timdonnelly deleted the tdonnelly/spm branch November 14, 2019 20:35
@watt
Copy link
Collaborator

watt commented Nov 14, 2019

Any idea why all these snapshots changed? Seems that they fail when running in Xcode 10.x now.

@watt
Copy link
Collaborator

watt commented Nov 14, 2019

Any idea why all these snapshots changed? Seems that they fail when running in Xcode 10.x now.

Actually it seems to be the result of running in iOS 13 instead of iOS 12.

@timdonnelly
Copy link
Contributor Author

Yeah, I scanned them for visual differences and they seemed ok.

@watt
Copy link
Collaborator

watt commented Nov 15, 2019

My concern is that this makes pod lib lint fail, because it does not choose an iOS 13 simulator to run the snapshot tests.

@timdonnelly
Copy link
Contributor Author

Which simulator does it use? It isn't specified in the podspec.

@timdonnelly
Copy link
Contributor Author

Another option is to run all tests via SPM, and only perform a build step with Cocoapods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleve kyleve kyleve approved these changes

@connorcimowsky connorcimowsky Awaiting requested review from connorcimowsky

@watt watt Awaiting requested review from watt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timdonnelly @watt @kyleve