Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Keyed element #210

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Add Keyed element #210

merged 1 commit into from
Apr 6, 2021

Conversation

kyleve
Copy link
Collaborator

@kyleve kyleve commented Apr 2, 2021

No description provided.

@kyleve kyleve force-pushed the kve/keyed-element branch from 78282c8 to 0d2f3dd Compare April 2, 2021 22:50
watt
watt approved these changes Apr 3, 2021
View reviewed changes
Copy link
Collaborator

@watt watt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to include a test.

@kyleve
Copy link
Collaborator Author

kyleve commented Apr 3, 2021

Happy to – though I struggled with what exactly to write – I guess a layout test?

@kyleve kyleve force-pushed the kve/keyed-element branch from 0d2f3dd to a0405d1 Compare April 3, 2021 02:29
@kyleve kyleve force-pushed the kve/keyed-element branch from a0405d1 to 993747b Compare April 6, 2021 04:33
@kyleve
Copy link
Collaborator Author

kyleve commented Apr 6, 2021

Added a couple tests

@kyleve kyleve enabled auto-merge April 6, 2021 04:35
@kyleve kyleve merged commit c273897 into main Apr 6, 2021
@watt watt deleted the kve/keyed-element branch November 24, 2021 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watt watt watt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyleve @watt