Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grid layout #156

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Remove grid layout #156

merged 1 commit into from
Sep 21, 2020

Conversation

kyleve
Copy link
Collaborator

@kyleve kyleve commented Sep 21, 2020

Remove GridLayout; it's incomplete and was never really intended to be consumed widely. The intended replacement is putting EqualStacks inside of a Column, or Rows inside a Column

…e consumed widely. The intended replacement is putting EqualStacks inside of a Column, or Rows inside a Column.
@kyleve kyleve force-pushed the kve/remove-grid-layout branch from 42021a1 to 6346c21 Compare September 21, 2020 18:01
Copy link
Contributor

@bencochran bencochran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there’s a case for something like Grid that’s not covered by EqualStack + Column (that is, equal-sized items across all rows and columns), but agree that the current state of this layout is pretty incomplete and could use a re-think overall.

@kyleve
Copy link
Collaborator Author

kyleve commented Sep 21, 2020

Yeah, agree. This ain't it, especially since this is a layout, not an element.

@kyleve kyleve merged commit 85c24cc into main Sep 21, 2020
@watt watt deleted the kve/remove-grid-layout branch November 24, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants