Set a shadow path on Box #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 12, 2020 10:51
|
|
|
Did a quick cursory glance to make sure no one in POS was relying on the old behavior, and everyone that specifies a shadow style also has a background color, so we should be safe with this |
|
Good thinking, thanks for checking @bencochran! |
kyleve
added a commit
that referenced
this pull request
Sep 10, 2020
* origin/main: (28 commits) Update CHANGELOG.md Add convenience methods for adding children to stacks Doc publishing github workflow jazzy doc generation Bump versions to 0.14.0 Update changelog Update release instructions Set a shadow path on Box (#137) Update changelog Add window size to environment Responsive layout demo with GeometryReader Add GeometryReader Update changelog for adding textColor on TextField Add textColor to TextField Default delaysContentTouches to true (#132) Update Tutorial2.md Update Tutorial2.md Update Tutorial2.md Update Tutorial2.md Update Element.md ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting an explicit shadow path improves performance, since the system doesn't have to draw the contents of the view offscreen first to figure out the shadow path itself. While this prevents the shadow from being applied to the view contents if the background is transparent, this seems like reasonable default behavior for
Boxsince it is, well, a "box."