Skip to content

Commit

Permalink
[Android] Fix a set of rendering issues introduced by single process …
Browse files Browse the repository at this point in the history 
…mode.

* There is browser side compositor in Android port, in single process mode. the
gl contexts in renderer will have race conditions with gl contexts in browser side.

* This issue leads to many rendering failes: (1) stop activity and then restart
will cause black screen; (2) Any page with compositing layers will leads to the
compositing layer black (WebGL. Canvas, Video).

* Fix this issue by duplicating the gl contexts implementation in browser side.

* This is a workaround fix for the critical blocking issue.

BUG=crosswalk-project/crosswalk#449, 430, 447, 455
  • Loading branch information
@sqliu
sqliu authored and Jesus Sanchez-Palencia committed Oct 7, 2013
1 parent 2fe0579 commit 508c5aa
Show file tree
Hide file tree
Showing 12 changed files with 4,840 additions and 22 deletions.
39 changes: 37 additions & 2 deletions content/browser/renderer_host/compositor_impl_android.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,13 @@
#include "cc/trees/layer_tree_host.h"
#include "content/browser/gpu/browser_gpu_channel_host_factory.h"
#include "content/browser/gpu/gpu_surface_tracker.h"
#include "content/browser/renderer_host/image_transport_factory_android.h"
#include "content/common/gpu/client/command_buffer_proxy_impl.h"
#include "content/common/gpu/client/context_provider_command_buffer.h"
#include "content/common/gpu/client/gl_helper.h"
#include "content/common/gpu/client/gl_helper_browser.h"
#include "content/common/gpu/client/gpu_channel_host.h"
#include "content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h"
#include "content/common/gpu/client/webgraphicscontext3d_command_buffer_browser_impl.h"
#include "content/common/gpu/gpu_process_launch_causes.h"
#include "content/public/browser/android/compositor_client.h"
#include "content/public/common/content_switches.h"
Expand Down Expand Up @@ -380,7 +382,8 @@ bool CompositorImpl::CopyTextureToBitmap(WebKit::WebGLId texture_id,
DCHECK(bitmap.size() == sub_rect.size());
if (bitmap.size() != sub_rect.size() || texture_id == 0) return false;

GLHelper* helper = ImageTransportFactoryAndroid::GetInstance()->GetGLHelper();
GLHelperBrowser* helper =
ImageTransportFactoryAndroid::GetInstance()->GetGLHelperBrowser();
helper->ReadbackTextureSync(texture_id,
sub_rect,
static_cast<unsigned char*> (bitmap.pixels()));
Expand Down Expand Up @@ -454,6 +457,38 @@ scoped_ptr<cc::OutputSurface> CompositorImpl::CreateOutputSurface(
if (!context_provider.get()) {
LOG(ERROR) << "Failed to create 3D context for compositor.";
return scoped_ptr<cc::OutputSurface>();
} else {
DCHECK(window_ && surface_id_);
GpuChannelHostFactory* factory = BrowserGpuChannelHostFactory::instance();
GURL url("chrome://gpu/Compositor::createContext3D");
scoped_ptr<WebGraphicsContext3DCommandBufferBrowserImpl> context(
new WebGraphicsContext3DCommandBufferBrowserImpl(
surface_id_,
url,
factory,
weak_factory_.GetWeakPtr()));
static const size_t kBytesPerPixel = 4;
gfx::DeviceDisplayInfo display_info;
size_t full_screen_texture_size_in_bytes =
display_info.GetDisplayHeight() *
display_info.GetDisplayWidth() *
kBytesPerPixel;
if (!context->Initialize(
attrs,
false,
CAUSE_FOR_GPU_LAUNCH_WEBGRAPHICSCONTEXT3DCOMMANDBUFFERIMPL_INITIALIZE,
64 * 1024, // command buffer size
std::min(full_screen_texture_size_in_bytes,
kDefaultStartTransferBufferSize),
kDefaultMinTransferBufferSize,
std::min(3 * full_screen_texture_size_in_bytes,
kDefaultMaxTransferBufferSize))) {
LOG(ERROR) << "Failed to create 3D context for compositor.";
return scoped_ptr<cc::OutputSurface>();
}
return scoped_ptr<cc::OutputSurface>(
new OutputSurfaceWithoutParent(
context.PassAs<WebKit::WebGraphicsContext3D>()));
}

return scoped_ptr<cc::OutputSurface>(
Expand Down
25 changes: 13 additions & 12 deletions content/browser/renderer_host/image_transport_factory_android.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
#include "base/strings/stringprintf.h"
#include "content/browser/gpu/browser_gpu_channel_host_factory.h"
#include "content/browser/renderer_host/compositor_impl_android.h"
#include "content/common/gpu/client/gl_helper.h"
#include "content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h"
#include "content/common/gpu/client/gl_helper_browser.h"
#include "content/common/gpu/client/webgraphicscontext3d_command_buffer_browser_impl.h"
#include "content/common/gpu/gpu_process_launch_causes.h"
#include "third_party/WebKit/public/platform/WebGraphicsContext3D.h"
#include "third_party/khronos/GLES2/gl2.h"
Expand Down Expand Up @@ -55,7 +55,7 @@ class DirectGLImageTransportFactory : public ImageTransportFactoryAndroid {
virtual WebKit::WebGraphicsContext3D* GetContext3D() OVERRIDE {
return context_.get();
}
virtual GLHelper* GetGLHelper() OVERRIDE { return NULL; }
virtual GLHelperBrowser* GetGLHelperBrowser() OVERRIDE { return NULL; }

private:
scoped_ptr<WebKit::WebGraphicsContext3D> context_;
Expand Down Expand Up @@ -94,11 +94,11 @@ class CmdBufferImageTransportFactory : public ImageTransportFactoryAndroid {
virtual WebKit::WebGraphicsContext3D* GetContext3D() OVERRIDE {
return context_.get();
}
virtual GLHelper* GetGLHelper() OVERRIDE;
virtual GLHelperBrowser* GetGLHelperBrowser() OVERRIDE;

private:
scoped_ptr<WebGraphicsContext3DCommandBufferImpl> context_;
scoped_ptr<GLHelper> gl_helper_;
scoped_ptr<WebGraphicsContext3DCommandBufferBrowserImpl> context_;
scoped_ptr<GLHelperBrowser> gl_helper_;

DISALLOW_COPY_AND_ASSIGN(CmdBufferImageTransportFactory);
};
Expand All @@ -109,10 +109,11 @@ CmdBufferImageTransportFactory::CmdBufferImageTransportFactory() {
GpuChannelHostFactory* factory = BrowserGpuChannelHostFactory::instance();
GURL url("chrome://gpu/ImageTransportFactoryAndroid");
base::WeakPtr<WebGraphicsContext3DSwapBuffersClient> swap_client;
context_.reset(new WebGraphicsContext3DCommandBufferImpl(0, // offscreen
url,
factory,
swap_client));
context_.reset(
new WebGraphicsContext3DCommandBufferBrowserImpl(0, // offscreen
url,
factory,
swap_client));
static const size_t kBytesPerPixel = 4;
gfx::DeviceDisplayInfo display_info;
size_t full_screen_texture_size_in_bytes =
Expand Down Expand Up @@ -185,9 +186,9 @@ void CmdBufferImageTransportFactory::AcquireTexture(
context_->flush();
}

GLHelper* CmdBufferImageTransportFactory::GetGLHelper() {
GLHelperBrowser* CmdBufferImageTransportFactory::GetGLHelperBrowser() {
if (!gl_helper_)
gl_helper_.reset(new GLHelper(context_.get()));
gl_helper_.reset(new GLHelperBrowser(context_.get()));

return gl_helper_.get();
}
Expand Down
3 changes: 2 additions & 1 deletion content/browser/renderer_host/image_transport_factory_android.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ class WebGraphicsContext3D;

namespace content {
class GLHelper;
class GLHelperBrowser;
class GLContextLostListener;

class ImageTransportFactoryAndroidObserver {
Expand All @@ -40,7 +41,7 @@ class ImageTransportFactoryAndroid {
uint32 texture_id, const signed char* mailbox_name) = 0;

virtual WebKit::WebGraphicsContext3D* GetContext3D() = 0;
virtual GLHelper* GetGLHelper() = 0;
virtual GLHelperBrowser* GetGLHelperBrowser() = 0;

static void AddObserver(ImageTransportFactoryAndroidObserver* observer);
static void RemoveObserver(ImageTransportFactoryAndroidObserver* observer);
Expand Down
12 changes: 8 additions & 4 deletions content/browser/renderer_host/render_widget_host_view_android.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@
#include "content/browser/renderer_host/image_transport_factory_android.h"
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/browser/renderer_host/surface_texture_transport_client_android.h"
#include "content/browser/renderer_host/touch_smooth_scroll_gesture_android.h"
#include "content/common/gpu/client/gl_helper.h"
#include "content/common/gpu/client/gl_helper_browser.h"
#include "content/common/gpu/gpu_messages.h"
#include "content/common/input_messages.h"
#include "content/common/view_messages.h"
Expand Down Expand Up @@ -253,12 +255,13 @@ WebKit::WebGLId RenderWidgetHostViewAndroid::GetScaledContentTexture(
if (out_size)
*out_size = size;

GLHelper* helper = ImageTransportFactoryAndroid::GetInstance()->GetGLHelper();
GLHelperBrowser* helper =
ImageTransportFactoryAndroid::GetInstance()->GetGLHelperBrowser();
return helper->CopyAndScaleTexture(texture_id_in_layer_,
texture_size_in_layer_,
size,
true,
GLHelper::SCALER_QUALITY_FAST);
GLHelperBrowser::SCALER_QUALITY_FAST);
}

bool RenderWidgetHostViewAndroid::PopulateBitmapWithContents(jobject jbitmap) {
Expand All @@ -272,14 +275,15 @@ bool RenderWidgetHostViewAndroid::PopulateBitmapWithContents(jobject jbitmap) {
// TODO(dtrainor): Eventually add support for multiple formats here.
DCHECK(bitmap.format() == ANDROID_BITMAP_FORMAT_RGBA_8888);

GLHelper* helper = ImageTransportFactoryAndroid::GetInstance()->GetGLHelper();
GLHelperBrowser* helper =
ImageTransportFactoryAndroid::GetInstance()->GetGLHelperBrowser();

WebKit::WebGLId texture = helper->CopyAndScaleTexture(
texture_id_in_layer_,
texture_size_in_layer_,
bitmap.size(),
true,
GLHelper::SCALER_QUALITY_FAST);
GLHelperBrowser::SCALER_QUALITY_FAST);
if (texture == 0)
return false;

Expand Down
Loading

0 comments on commit 508c5aa

Please sign in to comment.