add b64encoding and corresponding tests #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spyzhov
reviewed
Nov 6, 2022
ryzheboka
force-pushed
the
b64encoding
branch
from
aa83365 to
14b21d3
Compare
|
Thanks for the review! I pushed your suggestions. However, I struggle with formatting. How should I format it? |
spyzhov
reviewed
Nov 17, 2022
ryzheboka
force-pushed
the
b64encoding
branch
from
14b21d3 to
f883fd7
Compare
|
Thank you for the review! Your suggestions are pushed. |
spyzhov
reviewed
Nov 29, 2022
ryzheboka
force-pushed
the
b64encoding
branch
from
f883fd7 to
5b467a2
Compare
|
I am sorry for needing that many corrections. I'm still very inexperienced in go. Changes from last comment are pushed :) |
|
LGTM, later I will review and resolve errors from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add b64encode and b64decode with and without padding according to #50