Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetArray not working #22

Closed
nikalexey opened this issue Jun 10, 2020 · 3 comments · Fixed by #24
Closed

SetArray not working #22

nikalexey opened this issue Jun 10, 2020 · 3 comments · Fixed by #24
Labels
bug Something isn't working

Comments

@nikalexey
Copy link

Hello.
I need replace node in array
For example in JSON {"key": [1, 2, 3]} replace second index to another Node

vals := parent.MustArray()
vals[2] = anotherNode
parent.SetArray(vals)

and as result of Marshal received empty array {"key": []}
@spyzhov
Copy link
Owner

spyzhov commented Jun 11, 2020

Thanks, I'll check it.

@spyzhov spyzhov added the bug Something isn't working label Jun 11, 2020
spyzhov added a commit that referenced this issue Jun 13, 2020
@spyzhov
#22 fix SetArray and SetObject methods
2e00330
@spyzhov spyzhov mentioned this issue Jun 13, 2020
Merged
spyzhov added a commit that referenced this issue Jun 13, 2020
@spyzhov
#22 add tests
a541c8d
spyzhov added a commit that referenced this issue Jun 13, 2020
@spyzhov
#22 fix SetArray and SetObject methods (#24)
65a00d6
@spyzhov
Copy link
Owner

spyzhov commented Jun 13, 2020

Thanks! Fixed in v0.2.4

@nikalexey
Copy link
Author

Thank you for fast response. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#22 fix SetArray and SetObject methods spyzhov/ajson
2 participants
@nikalexey @spyzhov