Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix minor issues in the home page #69

Merged
merged 5 commits into from
Mar 2, 2018
Merged

PR: Fix minor issues in the home page #69

merged 5 commits into from
Mar 2, 2018

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Feb 27, 2018

Fixes #68

TODO:

  • Change favicon (possible need to delete cache to refresh favicon.ico)
  • Fix sticky navbar.
  • Width of the banner.
  • Working links in Team section.
  • Background colors of the sections.

@goanpeca
Copy link
Member

@ccordoba12 @dalthviz should I point spyder-ide.org to the actual site?

@dalthviz
Copy link
Member Author

@goanpeca I thought that we are going to do that after changing the style of the blog, althought I'm will have done that the next week probably :). So in a week or so maybe we should do the redirection of the domain?

@goanpeca
Copy link
Member

@dalthviz ok, ping me then ;-)

@dalthviz
Copy link
Member Author

@ccordoba12 a preview of the banner:

imagen

@ccordoba12
Copy link
Member

@dalthviz, I like it, it looks good. For the banner, please take the left part of image 2b (without the border) from

spyder-ide/spyder#6352 (comment)

@ccordoba12
Copy link
Member

Also, the width of the banner must be the same of the text below it.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @dalthviz! Let's merge this one, so I can give you feedback over the live website.

@ccordoba12 ccordoba12 changed the title PR: [WIP] Fix minor issues in the home page PR: Fix minor issues in the home page Mar 2, 2018
@ccordoba12 ccordoba12 merged commit 37a1483 into spyder-ide:master Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants