PR: Fix background color of information icon in File Switcher #9477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
changed the title
|
@juanis2112, this doesn't look good on Linux:
(and please also check how it looks on Windows). So you need to adjust things for each operating system. |
|
@juanis2112, please address my previous comment. As you can see, the information icon is almost not visible on Linux (although it's fine on macOS, according to your first screenshot). And you also need to check how things look on Windows. |
|
@ccordoba12 Sorry I missed the last comment. I will check it now |
|
No worries 👍 |
|
@juanis2112 @ccordoba12 this is a preview on Windows just in case:
|
|
Ok, thanks @dalthviz! So things look well everywhere, except in KDE (which is my Linux desktop environment). But I think that's a very small detail for @juanis2112 to invest more time on it. |
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Removed background and border color to information icon in file switcher so that it uses MAIN_FG_COLOR.
Issue(s) Resolved
Fixes #9442
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
Juanis2112