PR: Make a closebrackets extension for smarter brackets

[bcolsen]

Description of Changes

• Wrote at least one-line docstrings (for any new functions)
• Added unit test(s) covering the changes (if testable)
• Included a screenshot (if affecting the UI)

I made a CloseBrackets extension to the editor like the CloseQuotes extension

Issue(s) Resolved

Fixes #3414

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: bcolsen

[pep8speaks]

Hello @bcolsen! Thanks for updating the PR.

• In the file spyder/plugins/editor/extensions/tests/test_closebrackets.py, following are the PEP8 issues :

Line 67:23: E128 continuation line under-indented for visual indent

Comment last updated on January 29, 2019 at 06:53 Hours UTC

[CAM-Gerlach]

Seemed to work well in my basic functional testing so far! Just some minor style-related comments from me, aside from the remaining PEP 8 warnings.

Great addition @bcolsen ! Really useful feature.

[ccordoba12]

Hey @bcolsen, is this ready for review? (It looks like it is).

[bcolsen]

@ccordoba12 Yes it ready, I forgot to change the title.

[ccordoba12]

@bcolsen, everything looks great! I just have one question before merging: will selected text be enclosed by default in braces and quotes? Or do users have to activate an option in our preferences for that?

[bcolsen]

The current be behavior of closebrackets is that the entire extension isn't loaded when the option "Automatic insertion of parenthesis, brackets and braces" is unchecked. This was done to mirror the behavior of the closequotes. I could see that people would want to disable both of those separately, but it that could be done in a separate issue.

[CAM-Gerlach]

I could see that people would want to disable both of those separately, but it that could be done in a separate issue.

Yeah, I was thinking about that too, but I didn't want to overcomplicate this issue or break consistency with the auto quotes option. If we do separate them, I'd suggest adding surrounding characters (quotes + brackets) when text is selected be one separate option (since the usecase for the two is similar and the downsides are minimal), while keeping the insertion of the closing char on typing the opening one without anything selected be the two options they are now (since the use case/preference at least somewhat differs between them).

[CAM-Gerlach]

LGTM now!

[ccordoba12]

Thanks a lot @bcolsen! Great work here!!