Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Use single row for file name and path and use gray for paths in file switcher #8616

Merged
merged 3 commits into from
Jan 26, 2019

Conversation

juanis2112
Copy link
Contributor

@juanis2112 juanis2112 commented Jan 22, 2019

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot (if affecting the UI)

Changed file switcher to use a single row for a file name and its path and changed paths color to gray.

screen shot 2019-01-25 at 8 10 09 am

screen shot 2019-01-25 at 3 57 25 pm

Issue(s) Resolved

Part of #8580 (Items 1 and 3)

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
Juanis2112

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Could you align the file paths to the right instead of the left of the dialog? That way they wouldn't be so squished against the file names and would look much cleaner overall. Thanks!

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juanis2112! I left some comments to not hardcode the color and other details :)

spyder/widgets/fileswitcher.py Outdated Show resolved Hide resolved
spyder/widgets/fileswitcher.py Outdated Show resolved Hide resolved
@dalthviz
Copy link
Member

dalthviz commented Jan 23, 2019

About @CAM-Gerlach comment, what do you think @ccordoba12 ? From what I see in VSCode the paths are align to the left. Although, they seem kind of squished in the preview @juanis2112 uploaded as @CAM-Gerlach says, maybe we need to add more space between the path and the file name?

@CAM-Gerlach
Copy link
Member

Can we at least have a screenshot to see how it looks with them aligned to the right? Keeping them left might be fine, but they definitely need either more space or a separator of some sort.

@ccordoba12 ccordoba12 modified the milestones: v4.0beta3, v4.0beta2 Jan 23, 2019
@ccordoba12
Copy link
Member

This is looking really good, thanks @juanis2112!

About @CAM-Gerlach comment, what do you think @ccordoba12 ?

I don't like this idea too much, but we can add a bit more space between the file name and its path. @juanis2112, please do that in this PR.

@ccordoba12
Copy link
Member

@juanis2112, please update the screenshot in the PR description above to see your latest changes.

@dalthviz
Copy link
Member

About the color used for the path, @CAM-Gerlach can you make some suggestions? Also @juanis2112 could you upload a screenshot with the light theme to see how it looks like, thanks :)

@ccordoba12
Copy link
Member

@juanis2112, please also upload a screenshot for the light theme.

@ccordoba12 ccordoba12 changed the title Use single row for file name and path and use gray for paths PR: Use single row for file name and path and use gray for paths in file switcher Jan 25, 2019
@CAM-Gerlach
Copy link
Member

Actually, @dalthviz . #999999 may actually be the best choice after all, since the closest QDarkstyle palette color is #787878 which is even lower contrast than it is currently, when it already is at the lower limit of what I'd consider legible. I didn't realize it, but #999999 is also what we use at the comment color in the Spyder Dark theme, so it has precedent.

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juanis2112! LGTM 👍 What do you guys think @ccordoba12 @CAM-Gerlach ?

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. The path shortening behavior needs to be fixed but that's not really in scope here and I made a comment over on the issue instead. Thanks @juanis2112 !

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too. Thanks @juanis2112!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants