-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Use single row for file name and path and use gray for paths in file switcher #8616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Could you align the file paths to the right instead of the left of the dialog? That way they wouldn't be so squished against the file names and would look much cleaner overall. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @juanis2112! I left some comments to not hardcode the color and other details :)
About @CAM-Gerlach comment, what do you think @ccordoba12 ? From what I see in VSCode the paths are align to the left. Although, they seem kind of squished in the preview @juanis2112 uploaded as @CAM-Gerlach says, maybe we need to add more space between the path and the file name? |
Can we at least have a screenshot to see how it looks with them aligned to the right? Keeping them left might be fine, but they definitely need either more space or a separator of some sort. |
This is looking really good, thanks @juanis2112!
I don't like this idea too much, but we can add a bit more space between the file name and its path. @juanis2112, please do that in this PR. |
@juanis2112, please update the screenshot in the PR description above to see your latest changes. |
About the color used for the path, @CAM-Gerlach can you make some suggestions? Also @juanis2112 could you upload a screenshot with the light theme to see how it looks like, thanks :) |
@juanis2112, please also upload a screenshot for the light theme. |
Actually, @dalthviz . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @juanis2112! LGTM 👍 What do you guys think @ccordoba12 @CAM-Gerlach ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too. The path shortening behavior needs to be fixed but that's not really in scope here and I made a comment over on the issue instead. Thanks @juanis2112 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too. Thanks @juanis2112!
Description of Changes
Changed file switcher to use a single row for a file name and its path and changed paths color to gray.
Issue(s) Resolved
Part of #8580 (Items 1 and 3)
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
Juanis2112