Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix font color in dark theme for several widgets #8158

Merged
merged 3 commits into from
Nov 1, 2018

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Oct 28, 2018

Pull Request Checklist

  • Read and followed this repo's Contributing Guidelines
  • Based this PR on the latest version of the correct branch (master or 3.x)
  • Followed PEP 8 code style
  • Ensured this pull request hasn't eliminated unrelated blank lines/spaces,
    modified the spyder/defaults directory, or added new icons/assets
  • Described the changes and the motivation for them below if needed
  • Included a screenshot, if this PR makes any visible changes to the UI

Developer Certificate of Origin Affirmation

By submitting this Pull Request or typing my name below, I affirm the
Developer Certificate of Origin
with respect to both the content of the contribution itself and this post,
and understand I am releasing it under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

Description of Changes

Change font color to according to theme in various widgets:

  • File switcher
  • Symbol finder
  • Shortcuts table (preferences)
  • LSP table (preferences)
  • Find in files results

Issue(s) Resolved

Part of #8068

@pep8speaks
Copy link

Hello @dalthviz! Thanks for submitting the PR.

@dalthviz dalthviz added this to the v4.0beta2 milestone Oct 29, 2018
@dalthviz
Copy link
Member Author

@ccordoba12 a preview:

File Switcher

imagen

Symbol Finder

imagen

Preferences

imagen

Find in Files

imagen

@dalthviz dalthviz changed the title PR: [WIP] manage font color for widgets (fileswitcher - preferences tables - find in files results) PR: Manage font color for widgets (fileswitcher - preferences tables - find in files results) Oct 30, 2018
@ccordoba12 ccordoba12 changed the title PR: Manage font color for widgets (fileswitcher - preferences tables - find in files results) PR: Fix font color in dark theme for several widgets Oct 31, 2018
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 859effb into spyder-ide:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants