-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Separate startup run_lines with semicolon instead of comma #7597
Conversation
Hello @bcolsen! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on August 02, 2018 at 17:17 Hours UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like it. Thanks @bcolsen!
I'll merge after releasing a new version of spyder-kernels. |
"each one separated by commas, for " | ||
"example:<br>" | ||
"<i>import os, import sys</i>")) | ||
"each one separated by semicolons and a " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The semicolon and a space are only needed for python 2.7. Python 3 works without the space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll add that to our release notes for beta1 when I merge this one.
Pull Request Checklist
modified the
spyder/defaults
directory, or added new icons/assetsDescription of Changes
Currently IPython startup lines like these won't work in Sypder since the line is parsed with comma separated:
or
These common python import structures don't work in startup lines. I actually thought it was broken until I read the note in the ipython config and thought about the implications of using comma separation.
Solution
If we use semicolon to separate the lines like you can do in python then any valid python should be possible.
Then you could use:
Problem
This needs the new config parser form python 3 because semicolons are inline comments in config parser in python 2
Issue(s) Resolved
Associated With:
spyder-ide/spyder-kernels#15