PR: Add support for numeric literals with underscores highlighting in Python 3.6 #7505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @dalthviz! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on July 19, 2018 at 18:58 Hours UTC |
goanpeca
suggested changes
Jul 19, 2018
spyder/utils/syntaxhighlighters.py
Outdated
| r"\b[+-]?[0-9]+(?:\.[0-9]+)?(?:[eE][+-]?[0-9]+)?[jJ]?\b"] | ||
| # Needed to achieve correct highlighting in Python 3.6 | ||
| # See issue 7324 | ||
| if PY36: |
There was a problem hiding this comment.
this should be larger than and not tied to 36 right?
goanpeca
approved these changes
Jul 19, 2018
ccordoba12
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
modified the
spyder/defaultsdirectory, or added new icons/assetsDescription of Changes
Change regex for number syntax highlighting in Python 3.6 to support new numeric literal syntax.
A preview:
Issue(s) Resolved
Fixes #7324