Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix links to Travis CI and Google Group #7278

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

CAM-Gerlach
Copy link
Member

@CAM-Gerlach CAM-Gerlach commented Jun 11, 2018

Pull Request Checklist

  • Read and followed this repo's Contributing Guidelines
  • Based your PR on the latest version of the correct branch (master or 3.x)
  • Followed PEP8 for code style
  • Ensured your pull request hasn't eliminated unrelated blank lines/spaces,
    modified the spyder/defaults directory, or added new icons/assets
  • Wrote at least one-line docstrings for any new functions
  • Added at least one unit test covering the changes, if at all possible
  • Described your changes and the motivation for them below
  • Noted what issue(s) this pull request resolves, creating one if needed
  • Included a screenshot, if this PR makes any visible changes to the UI

Description of Changes

I hit "Request" next to your name under reviewers and github submitted the PR. Thanks, Github Microsoft.

...

Anyway, that nonsense aside, this just makes a few minor tweaks to the badges/links:

  • Updates the PyPI link to the new PyPI
  • Standardizes the links at the bottom with the others to use https on the Google Groups URL
  • Minor tweaks to the badge order for sensibility and standardization

As usual, you can preview the changes over on my fork.

Issue(s) Resolved

Very minor change to Readme; not needed.

@CAM-Gerlach CAM-Gerlach changed the base branch from master to 3.x June 11, 2018 19:28
@CAM-Gerlach CAM-Gerlach self-assigned this Jun 11, 2018
@CAM-Gerlach CAM-Gerlach requested a review from ccordoba12 June 11, 2018 19:30
@CAM-Gerlach CAM-Gerlach added this to the v3.3 milestone Jun 11, 2018
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure in Circle is unrelated and it'll be fixed in another PR.

@ccordoba12 ccordoba12 changed the title Fix links to Travis CI and Google Group, and add soft return PR: Fix links to Travis CI and Google Group Jun 11, 2018
@ccordoba12 ccordoba12 merged commit cd9588a into spyder-ide:3.x Jun 11, 2018
ccordoba12 added a commit that referenced this pull request Jun 11, 2018
@CAM-Gerlach CAM-Gerlach deleted the update-readme-badges branch July 8, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants