Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Set parent for Variable Explorer editors so Spyder closes properly #6703

Merged
merged 5 commits into from
Mar 11, 2018

Conversation

CAM-Gerlach
Copy link
Member

Fix #5696 .

Currently, any window launched from the Variable Explorer (Dataframe Editor, Collections Editor, etc) will cause Spyder to stay open even if the main window is closed, leading to extra resources and cluter, user confusion and general sub-optimal Ux. Therefore, this PR sets that properly to fix it, and additionally adds a specific test for this as well as improves the existing ones to make them less brittle (as this change broke one of them, my own). Also, updated file/section headers to the consistent standard and did a few bits of minor cleanup around lines that were changed.

@ccordoba12
Copy link
Member

@CAM-Gerlach, now this one needs a rebase :-)

@ccordoba12 ccordoba12 modified the milestones: v3.2.9, v3.2.8 Mar 10, 2018
@CAM-Gerlach CAM-Gerlach force-pushed the varexp-window-parent branch from 983173e to e45e1c9 Compare March 10, 2018 18:22
@CAM-Gerlach
Copy link
Member Author

@ccordoba12 Done. FYI, test_elapsed_time failed several times on the Python 3.6 builds of both AppVeyor and Travis; the AppVeyor build eventually passed while the Travis one failed all three times and I had to restart it, whence it eventually succeeded. Should I submit a PR to play with the timeouts, etc or if necessary just skip it on Py3.6, or do you have a better fix in mind?

@ccordoba12
Copy link
Member

I think increasing the timeouts should be enough. Thanks!

@CAM-Gerlach
Copy link
Member Author

CAM-Gerlach commented Mar 10, 2018

I think increasing the timeouts should be enough. Thanks!

@ccordoba12 Done, as a separate PR of course ( #6714 ). Did so on the two tests that were causing issues, along with related tweaks to a few other tests known to be flaky on Linux locally per you and jitseniesen .

Is there anything you need me to change/do on this one, or is it ready to merge? It should have been ready to go aside from the rebase as far as I'm aware.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CAM-Gerlach!

@ccordoba12 ccordoba12 changed the title PR: Set parent for Variable Explorer windows so Spyder closes properly, and improve tests PR: Set parent for Variable Explorer editors so Spyder closes properly Mar 11, 2018
@ccordoba12 ccordoba12 merged commit f9fa138 into spyder-ide:3.x Mar 11, 2018
ccordoba12 added a commit that referenced this pull request Mar 11, 2018
@CAM-Gerlach CAM-Gerlach deleted the varexp-window-parent branch March 11, 2018 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants