-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Set parent for Variable Explorer editors so Spyder closes properly #6703
Conversation
@CAM-Gerlach, now this one needs a rebase :-) |
983173e
to
e45e1c9
Compare
@ccordoba12 Done. FYI, |
I think increasing the timeouts should be enough. Thanks! |
@ccordoba12 Done, as a separate PR of course ( #6714 ). Did so on the two tests that were causing issues, along with related tweaks to a few other tests known to be flaky on Linux locally per you and jitseniesen . Is there anything you need me to change/do on this one, or is it ready to merge? It should have been ready to go aside from the rebase as far as I'm aware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CAM-Gerlach!
Fix #5696 .
Currently, any window launched from the Variable Explorer (Dataframe Editor, Collections Editor, etc) will cause Spyder to stay open even if the main window is closed, leading to extra resources and cluter, user confusion and general sub-optimal Ux. Therefore, this PR sets that properly to fix it, and additionally adds a specific test for this as well as improves the existing ones to make them less brittle (as this change broke one of them, my own). Also, updated file/section headers to the consistent standard and did a few bits of minor cleanup around lines that were changed.