Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Remove ipyconsole and editor attrs from the Help plugin #6587

Merged
merged 4 commits into from
Mar 4, 2018

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Mar 3, 2018

Fixes #6519.


The problem is those plugins are initialized after Help, so we can't set a reference to them in register_plugin.

The problem is they are initialized after Help, so we can't set a
reference to them in register_plugin.
@ccordoba12 ccordoba12 added this to the v3.2.8 milestone Mar 3, 2018
@pep8speaks
Copy link

pep8speaks commented Mar 3, 2018

Hello @ccordoba12! Thanks for updating the PR.

Line 224:80: E501 line too long (82 > 79 characters)

Comment last updated on March 03, 2018 at 19:01 Hours UTC

@ccordoba12
Copy link
Member Author

@CAM-Gerlach, could you test this PR on Windows to see if it fixes issue #6549? Thanks!

@CAM-Gerlach
Copy link
Member

Will do in the next few hours.

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still get the same error and fallback behavior when my working dir and spyder install are in different drives. No change yet with this PR :(

@CAM-Gerlach CAM-Gerlach dismissed their stale review March 4, 2018 03:26

Thought this was a fix for #6549 ....silly mistake.

@CAM-Gerlach
Copy link
Member

Sorry for the delay; I was helping another friend with programming issues and learning to use some of Spyder's features. Unfortunately, bad news...I still get the exact same behavior with regard to #6549 .

@ccordoba12
Copy link
Member Author

Ok, I was hoping for a simple fix, but no problem. We have to understand how to fix #6549 then.

@ccordoba12 ccordoba12 merged commit 9133839 into spyder-ide:3.x Mar 4, 2018
@ccordoba12 ccordoba12 deleted the plugins-order branch March 4, 2018 16:56
ccordoba12 added a commit that referenced this pull request Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants