PR: Show Help if closed when opening tutorial to avoid user confusion #6345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CAM-Gerlach, this has now a conflict with |
|
@ccordoba12 Yup; its with my other PR you just merged, as I expected would occur since they both needed to modify the same import line in |
CAM-Gerlach
force-pushed
the
open-help-tutorial
branch
from
fe7ca1a to
1372f59
Compare
CAM-Gerlach
force-pushed
the
open-help-tutorial
branch
from
1372f59 to
a531a59
Compare
|
Botched the |
ccordoba12
changed the title
ccordoba12
approved these changes
Feb 7, 2018
There was a problem hiding this comment.
Thanks @CAM-Gerlach! Very comprehensive tests for such a small fix ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6317 .
The actual change is a simple one, just showing the help plugin if it is closed or hidden when the user selects the tutorial from the help menu, for a better Ux and to avoid user confusion particularly when trying to learn the basics of Spyder. However, the more extensive changes are in some cleanup and minor fixes to the newly added help tests, and both unit and integration tests to cover this scenario as well as general help functionality.
Not a huge priority, but fits in the realm of user help/doc/error/quality of life improvements that 3.2.7 is centered around, so would be nice to have it in that.