-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Fix negative deltas on profiler #6106
Conversation
Hello @csabella! Thanks for updating the PR.
Comment last updated on January 04, 2018 at 17:39 Hours UTC |
@ccordoba12 In the first commit, I fixed the issue without making many other changes. However, I noticed that some of the code was no longer needed because the formatting had been changed at some point, so in the second commit, I refactored to remove some of the unneeded code. If you don't want those changes, I can remove the second commit. Thanks! |
Don't worry, it's fine. But I'd like to see some tests for this feature, if it's not much too ask :-) |
@ccordoba12 I've added some tests, but just for the methods that I modified. I had trouble calling this program since it was in Thanks! I can also work on tests for the rest of the class, but I thought you might want to this in the new release, so I wanted to get it to you. |
@csabella, I pushed one commit here to include the |
Fixes #6032