PR: Add validation for mimedata2url in Editor's dragEnterEvent #5694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
force-pushed
the
fixes_issue_5218
branch
from
7d8526f to
9fc49bd
Compare
ccordoba12
reviewed
Nov 8, 2017
There was a problem hiding this comment.
Thanks @dalthviz! Have you tested this on Windows and Linux?
I mean, could you post some Licecap captures to see how it works? Thanks!
|
@ccordoba12 a preview (Windows):
|
|
What about Linux? Does it work there too? |
|
I tried in Ubuntu but I don't manage to open a file from outside the File Explorer (with the change that this PR made or without it - current version):
|
|
Ok, no problem. At least the error won't show up anymore and it fixes things on Windows. |
ccordoba12
approved these changes
Nov 9, 2017
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5218