Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Don't unescape control characteres in replace in selection #5555

Merged
merged 3 commits into from
Nov 8, 2017
Merged

PR: Don't unescape control characteres in replace in selection #5555

merged 3 commits into from
Nov 8, 2017

Conversation

rlaverde
Copy link
Member

Fixes #5494

the regex \\(?![nrtf])(.) will replace escaped characters like \$, \# for $, #; but won't replace \n, \r, \t, \f, for n, r, t, f

@rlaverde rlaverde added this to the v3.2.5 milestone Oct 23, 2017
@rlaverde rlaverde self-assigned this Oct 23, 2017
@pep8speaks
Copy link

Hello @rlaverde! Thanks for submitting the PR.

Line 530:80: E501 line too long (80 > 79 characters)

@ccordoba12
Copy link
Member

ccordoba12 commented Oct 23, 2017 •
edited
Loading

@rlaverde, looks good but please add a test for this one.

@rlaverde rlaverde force-pushed the fix-error-replace-selection branch from 373e052 to 4889b9d Compare November 8, 2017 13:58
@rlaverde
Copy link
Member Author

rlaverde commented Nov 8, 2017

looks good but please add a test for this one.

Done

ccordoba12
ccordoba12 approved these changes Nov 8, 2017
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rlaverde!

@ccordoba12 ccordoba12 merged commit 7bb5275 into spyder-ide:3.x Nov 8, 2017
ccordoba12 added a commit that referenced this pull request Nov 8, 2017
@ccordoba12
Merge from 3.x: PR #5555
10c3b89 
Fixes #5494
@rlaverde rlaverde deleted the fix-error-replace-selection branch November 8, 2017 15:00
@CAM-Gerlach CAM-Gerlach mentioned this pull request Feb 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@rlaverde rlaverde

Labels
None yet
Projects
None yet
Milestone
v3.2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@rlaverde @pep8speaks @ccordoba12