PR: Add validation to not publish pdb_state after getting values of variables #5528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Oct 22, 2017
| @@ -65,6 +65,7 @@ def __init__(self, *args, **kwargs): | |||
| self.namespace_view_settings = {} | |||
| self._pdb_obj = None | |||
| self._pdb_step = None | |||
| self._publish_data = False | |||
There was a problem hiding this comment.
Let's change this variable name to _do_publish_data
ccordoba12
reviewed
Oct 22, 2017
| state = dict(namespace_view = self.get_namespace_view(), | ||
| var_properties = self.get_var_properties(), | ||
| step = self._pdb_step) | ||
| publish_data({'__spy_pdb_state__': state}) | ||
| self._publish_data = False |
There was a problem hiding this comment.
What happens if you open several variables while debugging? I think then this approach wouldn't work all the time.
There was a problem hiding this comment.
Do you mean like a synchronization issue?. A preview:
There was a problem hiding this comment.
Nice, it's working as expected!
dalthviz
force-pushed
the
fixes_issue_5036
branch
from
bb3eabd to
4237853
Compare
ccordoba12
reviewed
Oct 26, 2017
| @@ -212,11 +214,12 @@ def publish_pdb_state(self): | |||
| Publish Variable Explorer state and Pdb step through | |||
| publish_data. | |||
| """ | |||
| if self._pdb_obj: | |||
| if self._pdb_obj and not self._do_publish_data: | |||
There was a problem hiding this comment.
Let's change the logic here because it's a bit confuse. This should be
if self._pdb_obj and self._do_publish_data:to be clearer.
ccordoba12
reviewed
Oct 26, 2017
| @@ -157,6 +158,7 @@ def get_value(self, name): | |||
| # petitions to display a value | |||
| value = None | |||
| publish_data({'__spy_data__': value}) | |||
| self._do_publish_data = True | |||
There was a problem hiding this comment.
This needs to be False, meaning we don't publish data when we're getting values.
ccordoba12
reviewed
Oct 26, 2017
| state = dict(namespace_view = self.get_namespace_view(), | ||
| var_properties = self.get_var_properties(), | ||
| step = self._pdb_step) | ||
| publish_data({'__spy_pdb_state__': state}) | ||
| self._do_publish_data = False |
ccordoba12
reviewed
Oct 26, 2017
| @@ -65,6 +65,7 @@ def __init__(self, *args, **kwargs): | |||
| self.namespace_view_settings = {} | |||
| self._pdb_obj = None | |||
| self._pdb_step = None | |||
| self._do_publish_data = False | |||
There was a problem hiding this comment.
Sorry, but let's change this again to _do_publish_pdb_state
ccordoba12
approved these changes
Oct 26, 2017
ccordoba12
changed the title
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5036