Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Fix traceback error when selecting Next/Previous warning/error #5117

Merged
merged 2 commits into from
Sep 4, 2017
Merged

PR: Fix traceback error when selecting Next/Previous warning/error #5117

merged 2 commits into from
Sep 4, 2017

Conversation

csabella
Copy link
Contributor

@csabella csabella commented Sep 3, 2017

Fixes #5116.

@csabella csabella changed the title Fix traceback error when selecting Next/Previous warning/error PR: Fix traceback error when selecting Next/Previous warning/error Sep 3, 2017
@rlaverde
Copy link
Member

rlaverde commented Sep 3, 2017 •
edited
Loading

Thanks for catching this error, (It was my fault), I added some tests to that functions to avoid them to break again.

@csabella
Copy link
Contributor Author

csabella commented Sep 3, 2017

Thanks for adding the tests. I looked at it, but wasn't sure where to put them. I didn't realize they should be in their own source.

@ccordoba12 ccordoba12 added this to the v4.0beta1 milestone Sep 4, 2017
@ccordoba12
Copy link
Member

Thanks a lot @csabella for the fix and @rlaverde for the tests. Great work!!

@ccordoba12 ccordoba12 merged commit 26fd793 into spyder-ide:master Sep 4, 2017
@csabella csabella deleted the gotowarning branch September 4, 2017 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0beta1
Development

Successfully merging this pull request may close these issues.
3 participants
@csabella @rlaverde @ccordoba12