PR: Display prompt after errors #4914
Conversation
This solves issue spyder-ide#4504 but will sometimes display two `in[]`
|
|
|
@dhirschfeld, what do you think about @impact27's solution? |
| """ | ||
| Reimplemented to reset the prompt if the error comes after the reply | ||
| """ | ||
| super()._handle_error(msg) |
There was a problem hiding this comment.
I think this is wrong. It has to be
super(NamepaceBrowserWidget, self)._handle_error(msg)
Also, please move this addition to ShellWidget because it's not related to the Variable Explorer.
|
It seems a bit of a quirky solution - always insert an extra prompt after an exception and sometimes the exception will be printed in that prompt instead of associated with the prompt which caused it. That said, as a work-around I think it does lead to a better end-user experience as you don't have to escape out of a traceback anymore. If the underlying issue is with |
|
It is definitely a work-around. If this is an issue with |
|
Our tests are failing in PyQt4, but I'm not exactly sure how to fix them... |
|
If the error is "AttributeError: 'super' object has no attribute '_handle_error'" I could add a test to check if super has _handle_error? Worst case the msg is not handled, which means the error is not printed. I am not sure how this is happening? |
I agree with this option, but please do it only for PyQt4. There's a constant in
No idea either, but it's not so serious because very few people is using PyQt4 now. |
|
Hello @impact27! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on August 22, 2017 at 12:54 Hours UTC |
Fixes #4504.
This solves issue #4504 but will sometimes display two
in[]