Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update only current editor stack when moving tabs. #4850

Merged
merged 1 commit into from
Jul 30, 2017

Conversation

rlaverde
Copy link
Member

Fixes #4831

@rlaverde rlaverde added this to the v3.2.1 milestone Jul 28, 2017
@rlaverde rlaverde self-assigned this Jul 28, 2017
@rlaverde rlaverde requested a review from ccordoba12 July 28, 2017 23:37
@ccordoba12
Copy link
Member

Shouldn't we try to update all editor stacks? Or perhaps that's confusing...

@goanpeca, what do you think?

@goanpeca
Copy link
Member

@ccordoba12 I dont really use this feature so I am not sure what users expect :-|

@ccordoba12
Copy link
Member

Let's merge this for now because the bug is quite critical. I don't think users would expect that both windows should be synced when moving tabs.

@ccordoba12 ccordoba12 merged commit 03c616e into spyder-ide:3.x Jul 30, 2017
ccordoba12 added a commit that referenced this pull request Jul 30, 2017
@rlaverde
Copy link
Member Author

I don't think users would expect that both windows should be synced when moving tabs.

Personally I'll prefer the both windows to be totally independent, not only the position of the tabs not to be synced, but also different files opened, and when closing a tab to only be closed in that window

@goanpeca
Copy link
Member

Personally I'll prefer the both windows to be totally independent, not only the position of the tabs not to be synced, but also different files opened, and when closing a tab to only be closed in that window

Well.. that is not really the purpose of opening two editors... for that just open 2 instances of spyder

@ccordoba12
Copy link
Member

I agree with @goanpeca. @dalthviz is working on making all plugins to open a new window when detached from the main window, so we'll have to rethink this solution for Spyder 4.

@dalthviz, could you a open an issue about it, so we don't forget to address it? I think what we need to do is syncing tabs in both instances, so that when external windows are closed, tabs have the same order in the main window.

@rlaverde
Copy link
Member Author

Well.. that is not really the purpose of opening two editors... for that just open 2 instances of spyder

Normally I don't want all the files to be opened in two windows, and opening two different instances isn't the same It implies different console, explorer, find infiles.. etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants