PR: Fix enable/disable spinbox bug in Editor preferences panel #4759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the spinbox and slabel of the `edgeline_spin` and `occurrence_spin` widget were not disabled properly when their respective checkbox was unchecked. A connection was required between the checkbox toggled signal and the setEnabled slot of both the spinbox and slabel for this to work properly.
jnsebgosselin
changed the title
ccordoba12
approved these changes
Jul 30, 2017
There was a problem hiding this comment.
I tested this locally and it's working great.
Thanks @jnsebgosselin!
ccordoba12
changed the title
ccordoba12
added a commit
that referenced
this pull request
Jul 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the spinbox and slabel of the
edgeline_spinandoccurrence_spinwidget were not disabled properly when their respective checkbox was
unchecked.