PR: Add an option to set a custom HiDPI scale factor #4454

rlaverde · 2017-05-10T16:55:24Z

This is working, but It'll fail when setting variables that could be interpreted as int or floats (2, 2.5 but not 2;, 2.5;)

It'll be necessary to backport some changes from master (introduced by the multiple edgeline configuration)

The support for regex in config lineedit options. dc5d4a8
The change for preserving the type of preferences 0c9c97c and 5b26fe8

goanpeca · 2017-05-10T17:15:12Z

@ccordoba12 @rlaverde why dont use a single option + a QDoubleSpinBox? The default entry would be 1.0, why do we need an extra entry???? Also I would change to Enable high dpi scaling

Also the QDoubleSpinBox might return floats all the time?

rlaverde · 2017-05-10T19:21:34Z

Using a QDoubleSpinBox won't be necessary to backport the changes, but it won't allow configuration for multiple screens.

And I think that the differentiation between auto-scaling and custom-scalling is necessary (3 options)

ccordoba12 · 2017-05-10T21:46:36Z

It'll be necessary to backport some changes from master (introduced by the multiple edgeline configuration)

Ok, please backport the corresponding changes. They don't seem too disruptive, so we can have them in 3.2.

rlaverde · 2017-05-15T16:04:10Z

Ok, please backport the corresponding changes

Done 😄

ccordoba12 · 2017-05-15T20:54:39Z

spyder/config/main.py

              'high_dpi_scaling': False,
+              'high_dpi_custom_scale_factor': False,
+              'high_dpi_custom_scale_factors': '2;',


Please put here a float number, e.g. 1.5 or 2.5, so that people understand that they can adjust the scale factor to anything they want.

Also remove the ; at the end (which doesn't make sense for a single screen).

A float number could cause glitches, as said in the second question of this blog

Yeah, but that's something for users to try. The point is showing them that setting float factors is a possibility (and users on issue #4316 already made use of that possibility).

Also, is the colon really necessary? I'd prefer to remove it.

I changed it for "2.5", the ";" was necessary before backporting the changes

Ok, great!! Then 2.5 (without colon) it is :-)

ccordoba12 · 2017-05-15T20:56:06Z

spyder/plugins/configdialog.py

+                                tip=_("Set this for high DPI displays"))
+
+        custom_scaling_radio = self.create_radiobutton(
+                                _("Set a custom high DPI scaling"),


This tooltip needs to be more descriptive, i.e. we need to explain here that users can introduce non-integer scale factors and that they can also set factors for different screens, separated by colons.

We should also add a link to Qt documentation that explains this, like http://doc.qt.io/qt-5/highdpi.html

I don't know how to do that in a tooltip ;-)

I put the link in a label

Nice, thanks!!

ccordoba12 · 2017-05-15T20:58:07Z

I don't see here any adjustment for the contents of the Help plugin. @rlaverde, is that necessary or not?

rlaverde · 2017-05-16T14:14:06Z

I added more information of how to set this settings.

I don't see here any adjustment for the contents of the Help plugin. @rlaverde, is that necessary or not?

I forget about this, I'll try to do it, but I don't know how to test it

ccordoba12 · 2017-05-16T19:57:00Z

I forget about this, I'll try to do it, but I don't know how to test it

Just set a custom scale factor and verify that the text in the Help plugin also scales. If not, you'll have to search for a solution on the web.

ccordoba12 · 2017-05-16T21:31:57Z

@rlaverde, please ping me if/when you solve the problem with Help.

rlaverde · 2017-05-16T21:36:07Z

@ccordoba12 I'm testing and that seems to be an issue with QWebEngineView (also happens with spyder-reports), the QT wiki advice to set Qt.AA_EnableHighDpiScaling to True, but doesn't mention QT_SCREEN_SCALE_FACTORS

I tested with a minimal QWebEngineView and It doesn't scale

ccordoba12 · 2017-05-16T21:46:24Z

What if we try to scale things using CSS or something like that?

rlaverde · 2017-05-16T21:48:01Z

What if we try to scale things using CSS or something like that?

Maybe that will work, generate a CSS based in high_dpi_custom_scale_factors

ccordoba12 · 2017-05-16T21:49:00Z

Yes, exactly!

rlaverde · 2017-05-17T15:37:33Z

@ccordoba12 I think I found the error with Help plugin, font was being assigned sending a point size to method setFontSize() that receive a pixel size.

ccordoba12 · 2017-05-17T16:07:47Z

Nice!! Could you post a new screenshot with a custom scale factor?

Also, changing screen resolution requires a restart, so please be sure to demand a restart for the newly introduced options here.

rlaverde · 2017-05-17T16:11:15Z

Nice!! Could you post a new screenshot with a custom scale factor?

goanpeca · 2017-05-17T16:11:40Z

I will be test this in the afternoon, going out now.

ccordoba12 · 2017-05-17T16:13:02Z

Ok, things look really good so far. The only thing missing is requiring a restart, and that would be it :-)

rlaverde · 2017-05-17T17:18:19Z

The only thing missing is requiring a restart, and that would be it :-)

Done, although I don't find a easy way to manage the preferences as a group, and set the restart for each preference.

ccordoba12 · 2017-05-17T20:27:24Z

I'll leave @goanpeca the final word for this one.

This reverts commit f053593.

…t.py

Remove exported QT_SCREEN_SCALE_FACTORS when option is False.

Fix alignation error in mac.

Fixes #4316

rlaverde added this to the v3.2 milestone May 10, 2017

rlaverde self-assigned this May 10, 2017

rlaverde requested review from ccordoba12 and goanpeca May 10, 2017 16:55

ccordoba12 reviewed May 15, 2017

View reviewed changes

rlaverde force-pushed the hidpi-custom-scale-factor branch from 1c1dd88 to 92c833f Compare May 16, 2017 20:55

goanpeca assigned goanpeca and unassigned rlaverde May 17, 2017

rlaverde added 2 commits June 1, 2017 10:17

Add options for scren resolution (hidpi).

d0f9c4e

Remove regex because is not supported in spyder 3.x.

9eeae62

rlaverde added 14 commits June 1, 2017 10:17

Set QT_SCREEN_SCALE_FACTORS before creating the app.

563c088

Add regex validator to lineedit preferences

f271504

Change UserConfig get method to avoid to convert str to tuples or list

7ee59b9

Try to eval string setting values after decoding in python2.7

0562ff7

Revert "Remove regex because is not supported in spyder 3.x."

24270b4

This reverts commit f053593.

Change default value of high_dpi_custom_scale_factors.

09fc526

Add more information to screen resolutions settings.

0a5970a

Support floats in high_dpi_custom_scale_factors configuration.

0402617

Fix error with Help plugin don't scaling correctly.

18dc33b

Restart when changing screen resolution configuration.

6d45ce9

Move QT_SCREEN_SCALE_FACTORS os.environ export to start.py and restar…

6080501

…t.py

Fix error when changing to normal hidpi.

8fafe45

Remove exported QT_SCREEN_SCALE_FACTORS when option is False.

Screen resolution preferences, change layout to GridLayout.

ac42190

Fix alignation error in mac.

Change high_dpi_custom_scale_factors default to 1.5

ef8b639

rlaverde force-pushed the hidpi-custom-scale-factor branch from ed92f34 to ef8b639 Compare June 1, 2017 15:18

ccordoba12 approved these changes Jun 1, 2017

View reviewed changes

ccordoba12 changed the title ~~PR: Add an option for a custom hidpi scale factor~~ PR: Add an option to set a custom HiDpi scale factor Jun 1, 2017

ccordoba12 merged commit 5cfda77 into spyder-ide:3.x Jun 1, 2017

ccordoba12 added a commit that referenced this pull request Jun 1, 2017

Merge from 3.x: PR #4454

c4d0136

Fixes #4316

rlaverde deleted the hidpi-custom-scale-factor branch June 1, 2017 16:16

ccordoba12 changed the title ~~PR: Add an option to set a custom HiDpi scale factor~~ PR: Add an option to set a custom HiDPI scale factor Jun 1, 2017

This was referenced Jun 2, 2017

PR: Fix font size for the Help plugin #4544

Merged

"use symbolic math" fontifies (incorrectly scaled) data structures #4556

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: Add an option to set a custom HiDPI scale factor #4454

PR: Add an option to set a custom HiDPI scale factor #4454

rlaverde commented May 10, 2017 •

edited by ccordoba12

Loading

goanpeca commented May 10, 2017 •

edited

Loading

rlaverde commented May 10, 2017

ccordoba12 commented May 10, 2017 •

edited

Loading

rlaverde commented May 15, 2017

ccordoba12 May 15, 2017 •

edited

Loading

rlaverde May 16, 2017

ccordoba12 May 16, 2017

ccordoba12 May 16, 2017

rlaverde May 16, 2017

ccordoba12 May 16, 2017

ccordoba12 May 15, 2017

goanpeca May 16, 2017

ccordoba12 May 16, 2017

rlaverde May 16, 2017

ccordoba12 May 16, 2017

ccordoba12 commented May 15, 2017

rlaverde commented May 16, 2017

ccordoba12 commented May 16, 2017

ccordoba12 commented May 16, 2017

rlaverde commented May 16, 2017 •

edited

Loading

ccordoba12 commented May 16, 2017

rlaverde commented May 16, 2017

ccordoba12 commented May 16, 2017

rlaverde commented May 17, 2017

ccordoba12 commented May 17, 2017

rlaverde commented May 17, 2017

goanpeca commented May 17, 2017

ccordoba12 commented May 17, 2017

rlaverde commented May 17, 2017

ccordoba12 commented May 17, 2017

PR: Add an option to set a custom HiDPI scale factor #4454

PR: Add an option to set a custom HiDPI scale factor #4454

Conversation

rlaverde commented May 10, 2017 • edited by ccordoba12 Loading

goanpeca commented May 10, 2017 • edited Loading

rlaverde commented May 10, 2017

ccordoba12 commented May 10, 2017 • edited Loading

rlaverde commented May 15, 2017

ccordoba12 May 15, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ccordoba12 commented May 15, 2017

rlaverde commented May 16, 2017

ccordoba12 commented May 16, 2017

ccordoba12 commented May 16, 2017

rlaverde commented May 16, 2017 • edited Loading

ccordoba12 commented May 16, 2017

rlaverde commented May 16, 2017

ccordoba12 commented May 16, 2017

rlaverde commented May 17, 2017

ccordoba12 commented May 17, 2017

rlaverde commented May 17, 2017

goanpeca commented May 17, 2017

ccordoba12 commented May 17, 2017

rlaverde commented May 17, 2017

ccordoba12 commented May 17, 2017

rlaverde commented May 10, 2017 •

edited by ccordoba12

Loading

goanpeca commented May 10, 2017 •

edited

Loading

ccordoba12 commented May 10, 2017 •

edited

Loading

ccordoba12 May 15, 2017 •

edited

Loading

rlaverde commented May 16, 2017 •

edited

Loading