PR: Improvements to visual style of code-folding #4265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goanpeca
approved these changes
Mar 16, 2017
|
@rlaverde, really nice!! Please rebase on top of master to fix the hangup on CircleCI. |
- Replace native_look for native icons. - Delete unused static method get_system_bck_color.
- Use scope_highlight_color based in sideareas_color.
rlaverde
force-pushed
the
folding-panel-style
branch
from
aa68a91 to
cdf27cc
Compare
ccordoba12
approved these changes
Mar 21, 2017
|
this is much better. Thanks @rlaverde! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4147
Now It looks like this:
And in darker themes:
This was one of the things after #3833