PR: Fix error edge line in python2.7 #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rlaverde now that you did this. Could we add a test to find with a regex or something
|
I added it in the last commit, what do you think? |
ccordoba12
approved these changes
Feb 17, 2017
ccordoba12
force-pushed
the
fix/edge-line-py2.7
branch
from
bb6a81b to
7811fb8
Compare
ccordoba12
reviewed
Feb 17, 2017
| @@ -94,7 +94,7 @@ def get(self, name_or_klass): | |||
| :param name_or_klass: Name or class of the panel to retrieve. | |||
| :return: The specified panel instance. | |||
| """ | |||
| if not isinstance(name_or_klass, str): | |||
| if not is_text_string(name_or_klass, str): | |||
There was a problem hiding this comment.
@rlaverde, this call is wrong because is_text_string only receives one argument.
ccordoba12
reviewed
Feb 17, 2017
| @@ -76,7 +76,7 @@ def start(self): | |||
| data = page.read() | |||
|
|
|||
| # Needed step for python3 compatibility | |||
| if not isinstance(data, str): | |||
| if not is_text_string(data, str): | |||
There was a problem hiding this comment.
This is also wrong, and it's what's making our tests to time out in master because checking if there's a new Spyder version is failing now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4153