PR: Gracefully handle ValueError in DataFrameModel #4142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goanpeca
approved these changes
Feb 13, 2017
|
@ccordoba12 should we made this fix against 3.x ? or ? |
|
Yes, I wanted this to go against 3.1.x ... wait a minute ... |
|
This is ready as far as I am concerned. No idea what is happening with the tests. |
This handles the case where the data frame contains a NaN and the user specifies the format '%d'. Fixes spyder-ide#4139.
jitseniesen
force-pushed
the
issue-4139
branch
from
7bd3cc2 to
b7394d2
Compare
ccordoba12
approved these changes
Feb 14, 2017
|
@jitseniesen, I introduced new tests for the main window last week and they are failing sometimes. I'm still trying to determine what tests need to be disabled in what Cis. |
ccordoba12
changed the title
ccordoba12
added a commit
that referenced
this pull request
Feb 14, 2017
This was referenced Mar 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the case where the data frame contains a NaN and the user specifies the format
%d. Fixes #4139.