PR: Add a flag to use case sensitive search/replace #4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we add a test :-p ? |
|
Yep, please add a test ;-) |
goanpeca
reviewed
Jan 31, 2017
spyder/utils/fixtures.py
Outdated
| widget.setup_editor(linenumbers=True, markers=True, tab_mode=False, | ||
| font=QFont("Courier New", 10), | ||
| show_blanks=True, color_scheme='Zenburn') | ||
| widget.setup_editor(language='Python') |
There was a problem hiding this comment.
Why is this 2 steps? and not just this (widget.setup_editor(language='Python')) one?
There was a problem hiding this comment.
Are we not using this bot on the tests?
There was a problem hiding this comment.
Yeah, it seems you added this bot but at the end you're not using it :-/
There was a problem hiding this comment.
Both are right, I forgot to change that bot for the one that I'm using and that is in test_editor.py 😖
ccordoba12
reviewed
Jan 31, 2017
| editorStack.find_widget.replace_find() | ||
| editorStack.find_widget.replace_find() | ||
| editor_text = editor.toPlainText() | ||
| assert editor_text == ' pass \nTEST \nTest \ntesT ' |
ccordoba12
approved these changes
Jan 31, 2017
goanpeca
approved these changes
Jan 31, 2017
ccordoba12
added a commit
that referenced
this pull request
Jan 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4072