PR: Save file with original encoding if possible #3929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlaverde
changed the title
|
Great job, now this works as expected :-) |
ccordoba12
reviewed
Jan 7, 2017
| if orig_coding: | ||
| try: | ||
| return text.encode(orig_coding), orig_coding | ||
| except UnicodeError: |
There was a problem hiding this comment.
@rlaverde, I failed to see that in all other places we except in two errors: UnicodeError and LookupError. This shouldn't be an exception.
Please fix that in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3753
encodings.write()will try to save the file with the original encoding as first option.