PR: IPython Console adapts to Spyder color scheme

[mariacamilarg]

Fixes #916

[mariacamilarg]

@ccordoba12 This PR still have lots of style corrections to be made so please ignore them for now, I will correct them when the content is approved.

I have 2 main problems here (a big and a small one):

• big: when changing the color scheme, the new one is defined and set but for some reason qtconsole only updates the style_sheet and not the syntax_style (even though I call jyputer_widget's self._style_sheet_changed() and self._syntax_style_changed()). So I think this is a qtconsole problem because is only refreshing half of it. However when restarting spyder it works good. But I know this is not the objective and what I find weird is that it does update a part. I also checked if maybe the syntax was not being updated correctly (but it is!).

• small: I want to sent the selection_background_color and the error_color in the style_sheet, however I can't find them in spyder. They are not in the color_scheme values. Do you know where they are?

Apart from this I think everything is working. It took me a lot to figure out a way to set the syntax but I hope you like it :)

[ccordoba12]

This is so nice!! Thanks a lot for working on this!

For now, one important comment: you did this PR against master and not 3.x, so you prefer this to go for Spyder 4?

[ccordoba12]

About your problems:

1. What happens if you just restart an IPython console after changing schemes? Does it fix this problem?
2. What are those colors used for?

[ccordoba12]

Another important thing to consider is what happens with colors for tracebacks. Did you try them with different schemes @mariacamilaremolinagutierrez?

[mariacamilarg]

@ccordoba12 Oh I'm sorry, I have no preference, I just did the PR to master because I thought new features went there. But if it is sooner for me is better :) About the comments:

1. If I just hit apply and ok in the settings, the editor gains the new scheme but the console doesn't. You have to close it (as it was before with the light and dark settings). After closing the console, when the next Console 2/A is opened, is that the consoles gets updated (but only stylesheet, not syntax). I tried restarting the kernel but that doesn't help. Is only after restarting spyder. I wanted to try this in qtconsole directly but once the console is running I can't seem to find a way of changing its display, only when calling python -m qtconsole --style 'name_of_syntax_style_file' . Do you know if there's a way? I could try adding a quick pop up in qtconsole to run these same updates with a different scheme to check if it is spyder or qt. How does this sound?

2. selection_background_color is the color used when you select some text, I check and in all the spyder themes is always this blue:

Do you know where in spyder is this blue color set? So I can put it in the style_sheet of the console.

And error_color I think is now part of spyder now that I realize, because the editor would never need to show this (this I think is related to the traceback you just mentioned). So what I'm thinking for it (as we don't set it for the themes) is taking the same color of another thing in the theme (to guarantee it is going to be visible). What do you think?

[ccordoba12]

I just did the PR to master because I thought new features went there. But if it is sooner for me is better :)

There are two types of changes:

1. Additions that break our current API or move/delete a lot of code (e.g. the code folding work of @rlaverde). They must done in master.
2. Additions that don't break our API (e.g. this case) or bugfixes. They can be done in 3.x.

So if you want to see this released sooner, you need to redo your PR against 3.x :-)

---

About the comments:

1. I really don't know how the style can be changed while qtconsole is running. This looks like new functionality we need to add to qtconsole :-)
2. I don't think we define selection_background_color but we could add it to our color schemes. About error_color, we have to take a look at it carefully because tracebacks are colored using other mechanisms in qtconsole.

---

I think this work is going to be delayed to 3.2 because there are still several things we need to look at and the feature freeze for 3.1 is almost here :-) But great job at making this work!

[mariacamilarg]

@ccordoba12:

About the branch, this latest commit will be the last in this PR. I will re do it but checking out from 3.x now.

About the comments:

1. I made this PR to try to do it ([WIP] Switching syntax styles option jupyter/qtconsole#184) but as I comment there, I can only manage to change the color when creating a new tab (i.e. calling new_frontend_master() inside qtconsole/qtconsoleapp.py). In this new commit I am attempting to do the same. However calling create_new_client() inside spyder/plugins/ipythonconsole.py (with the new config options updated) does not have the same effect. Do you know what is the homologous for new_frontend_master() in spyder/plugins/ipythonconsole.py?

2. If we don't define never selection_background_color, where is that color of blue coming from? About error_color, I'll check it after I figure out these problems first.

[ccordoba12]

1. Please check how we change color schemes in the Editor. I'm sure this can be done at the widget level, without restarting or opening new files. That code probably needs to be added to qtconsole too.
2. That blue must come from Qt, but I agree we should define it in our color schemes. However, that's work for another PR, so please don't add those changes here :-)

[goanpeca]

styles = 
{
  'Name.Class': [definition_font_style, definition_font_weight, definition_color,
}

create_style_strng(dic):
return str

with open(): {
   f.write(str)
}