Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Don't show TextEditor if it fails to be initialized #3906

Merged
merged 5 commits into from
Jun 1, 2017

Conversation

mariacamilarg
Copy link
Contributor

Fixes #3673

@ccordoba12 ccordoba12 added this to the v3.1 milestone Jan 2, 2017
@ccordoba12
Copy link
Member

@mariacamilaremolinagutierrez, this is not the solution I asked you to implement. What I want is for you to add a method called setup_and_check to the TextEditor class, and use it to verify if it's able to display strings passed to it. setup_and_check must return True is there are no problems and False otherwise.

Besides, please add a test for that method using the code I put on issue #3673 in

spyder/widgets/variableexplorer/tests/test_texteditor.py

@ccordoba12 ccordoba12 modified the milestones: v3.1, v3.2 Jan 8, 2017
@mariacamilarg
Copy link
Contributor Author

@ccordoba12 This is ready :)

@ccordoba12 ccordoba12 changed the title PR: If TextEditor fails to be initialized, it is not shown in the Variable Explorer PR: Don't show TextEditor if it fails to be initialized Jun 1, 2017
@ccordoba12 ccordoba12 merged commit 51e8a02 into spyder-ide:3.x Jun 1, 2017
ccordoba12 added a commit that referenced this pull request Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants