PR: Add disambiguation functionality to the Python console #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A preview of the change:
|
ccordoba12
changed the title
ccordoba12
reviewed
Dec 17, 2016
| return ima.icon('console') | ||
|
|
||
| def get_focus_widget(self): | ||
| """ | ||
| Return the widget to give focus to when | ||
| this plugin's dockwidget is raised on top-level | ||
| this plugin's dockwidget is raised on top-level. |
There was a problem hiding this comment.
To fix this docstyle error you need to rewrite this docstring as
"""Return the widget to give focus to when
this plugin's dockwidget is raised on top-level"""
ccordoba12
reviewed
Dec 17, 2016
| this plugin's dockwidget is raised on top-level | ||
| """ | ||
| """Return the widget to give focus to when | ||
| this plugin's dockwidget is raised on top-level""" |
There was a problem hiding this comment.
Let's change it to """Return the widget to give focus to.""" to fix the style error.
|
Since style tests are now passing, please squash the last four commits into one and push again :-) |
dalthviz
force-pushed
the
fixes_issue_1165
branch
from
2da58f5 to
be0a64c
Compare
ccordoba12
changed the title
|
Looks good to me, thanks @dalthviz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1165