-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Fixed encoding issue when changing cwd in the IPython console #3813
Conversation
@@ -33,7 +33,7 @@ def log_last_error(fname, context=None): | |||
print("Context", file=fd) | |||
print("-------", file=fd) | |||
print("", file=fd) | |||
print(context, file=fd) | |||
print(u' '.join(context).encode('utf-8').strip(), file=fd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you have to do this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was needed because an error was thrown in the python console when changing the directory to one with non - ascii name. Actually was really strange when I saw it. I also saw that the error causes that a process in the python console crashes and then, if you try to change again the working directory, Spyder crashes too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the crash only occurs on Python 2? Or on Python 3 too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It only occurs with Python 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then please apply this change only for Python 2 and leave the previous line for Python 3
…unning with Python 2.
Thanks @dalthviz, this looks good now :-) |
Fixes #3807
Fixes #3407
Edit: Include reference to a related issue.