PR: add "Save copy as..." to file menu #3362
Conversation
| if editorstack.save_copy_as(): | ||
| fname = editorstack.get_current_filename() | ||
| if CONF.get('workingdir', 'editor/save/auto_set_to_basedir'): | ||
| self.emit(SIGNAL("open_dir(QString)"), osp.dirname(fname)) |
There was a problem hiding this comment.
We don't support the old style of signals and slots anymore because it's incompatible with PyQt5. You need to change this instead to:
self.open_dir.emit(osp.dirname(fname))
|
Thanks a lot for your contribution!! This looks good to me, except for the comments I left. Once you do those changes, I can give a live try to your work to see if it's working correctly :-) |
|
@ahed87 thanks for the contribution, could you rebase or merge to resolve conflicts? |
goanpeca
changed the title
|
hm, git and I are still not friends. |
|
If this last "assigned" means that I should do something please give me a hint of what to do. |
|
Closed in favor of #4523 |
|
@ahed87, thanks a lot for your work (and sorry for the big delay in review it). It'll be part of Spyder 3.2. |
Just for convenience.
Changes are working on a local install, but could very well be messed up, since the commits are done with copy/paste on web.
I suppose github and I will be better friends in the future...