Fix interrupt handling on Windows #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that we are here, I'd like to ask: @blink1073 you added pywin32 to close completion processes after a crash, right? So my question is: should we make it a hard dependency? At least now, Spyder doesn't start on Windows if pywin32 is not present. |
|
Yep, I think requiring |
|
Could you elaborate a bit more? El 25/03/16 a las 12:01, Steven Silvester escribió:
|
|
Oh, I see what you mean, updating. |
|
Fixed. |
|
Thanks @blink1073 :-) |
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows
SetConsoleCtrlHandlerwas only sending one argument to the function.